nsivabalan commented on code in PR #14191:
URL: https://github.com/apache/hudi/pull/14191#discussion_r2479523525
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/upgrade/UpgradeDowngradeUtils.java:
##########
@@ -215,6 +224,40 @@ static void rollbackFailedWritesAndCompact(HoodieTable
table, HoodieEngineContex
}
}
+ static void setPropertiesBasedOnMetadataPartitions(HoodieWriteConfig
rollbackWriteConfig,
+ Set<String>
existingMetadataPartitions) {
+ if (existingMetadataPartitions.isEmpty()) {
+ rollbackWriteConfig.setValue(HoodieMetadataConfig.ENABLE.key(), FALSE);
+ return;
+ }
+
+ rollbackWriteConfig.setValue(HoodieMetadataConfig.ENABLE.key(), TRUE);
+ for (String partition : existingMetadataPartitions) {
+ switch (partition) {
+ case HoodieTableMetadataUtil.PARTITION_NAME_COLUMN_STATS:
+
rollbackWriteConfig.setValue(HoodieMetadataConfig.ENABLE_METADATA_INDEX_COLUMN_STATS.key(),
TRUE);
+ break;
+ case HoodieTableMetadataUtil.PARTITION_NAME_BLOOM_FILTERS:
+
rollbackWriteConfig.setValue(HoodieMetadataConfig.ENABLE_METADATA_INDEX_BLOOM_FILTER.key(),
TRUE);
+ break;
+ case HoodieTableMetadataUtil.PARTITION_NAME_PARTITION_STATS:
+
rollbackWriteConfig.setValue(HoodieMetadataConfig.ENABLE_METADATA_INDEX_COLUMN_STATS.key(),
TRUE);
+ break;
+ case HoodieTableMetadataUtil.PARTITION_NAME_SECONDARY_INDEX:
+
rollbackWriteConfig.setValue(HoodieMetadataConfig.SECONDARY_INDEX_ENABLE_PROP.key(),
TRUE);
+ break;
Review Comment:
for secondary and expression index, we don't need to set this. we have diff
ways to drop them. the auto detect and drop is not applicable to those.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/upgrade/UpgradeDowngradeUtils.java:
##########
@@ -215,6 +224,40 @@ static void rollbackFailedWritesAndCompact(HoodieTable
table, HoodieEngineContex
}
}
+ static void setPropertiesBasedOnMetadataPartitions(HoodieWriteConfig
rollbackWriteConfig,
+ Set<String>
existingMetadataPartitions) {
+ if (existingMetadataPartitions.isEmpty()) {
+ rollbackWriteConfig.setValue(HoodieMetadataConfig.ENABLE.key(), FALSE);
+ return;
+ }
+
+ rollbackWriteConfig.setValue(HoodieMetadataConfig.ENABLE.key(), TRUE);
+ for (String partition : existingMetadataPartitions) {
+ switch (partition) {
+ case HoodieTableMetadataUtil.PARTITION_NAME_COLUMN_STATS:
+
rollbackWriteConfig.setValue(HoodieMetadataConfig.ENABLE_METADATA_INDEX_COLUMN_STATS.key(),
TRUE);
+ break;
+ case HoodieTableMetadataUtil.PARTITION_NAME_BLOOM_FILTERS:
+
rollbackWriteConfig.setValue(HoodieMetadataConfig.ENABLE_METADATA_INDEX_BLOOM_FILTER.key(),
TRUE);
+ break;
+ case HoodieTableMetadataUtil.PARTITION_NAME_PARTITION_STATS:
+
rollbackWriteConfig.setValue(HoodieMetadataConfig.ENABLE_METADATA_INDEX_COLUMN_STATS.key(),
TRUE);
+ break;
+ case HoodieTableMetadataUtil.PARTITION_NAME_SECONDARY_INDEX:
+
rollbackWriteConfig.setValue(HoodieMetadataConfig.SECONDARY_INDEX_ENABLE_PROP.key(),
TRUE);
+ break;
+ case HoodieTableMetadataUtil.PARTITION_NAME_EXPRESSION_INDEX:
+
rollbackWriteConfig.setValue(HoodieMetadataConfig.EXPRESSION_INDEX_ENABLE_PROP.key(),
TRUE);
+ break;
+ case HoodieTableMetadataUtil.PARTITION_NAME_RECORD_INDEX:
+
rollbackWriteConfig.setValue(HoodieMetadataConfig.RECORD_INDEX_ENABLE_PROP.key(),
TRUE);
Review Comment:
this is tricky.
it could either be global rli or non global rli.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
