hudi-bot opened a new issue, #14646:
URL: https://github.com/apache/hudi/issues/14646
* Add java docs to KeyGeneratorInterface methods.
* validateRecordKeyFields() in CustomKeyGenerator could be moved up and
used by other keyGens. Check and fix it.
* Unify usage of getters. For eg. in SimpleKeyGen we have something like
RowKeyGeneratorHelper.getRecordKeyFromRow(row, getRecordKeyFields(),
recordKeyPositions, false);
for recordKeyFields, we use getRecordKeyFields(), where as for
recordKeyPositions we use instance variable directly. Make it uniform in all
key gen classes.
* Remove line 82 in
[TestGlobalDeleteKeyGenerator.java|https://github.com/apache/hudi/commit/5dc8182ec308dba7ffd04ef159bd3041ede1b117#diff-4c306975590fe7bf2b27a6f5a9d9ff7e]
keyGenerator.buildFieldPositionMapIfNeeded(KeyGeneratorTestUtilities.structType);
* make buildFieldPositionMapIfNeeded(StructType structType) in
BuildInKeyGen as protected.
* Introduce private method (and re-use) to generate positions for
recordkeys and partition paths.
* boolean positionMapInitialized in buildMapPositionsIfNeeded
## JIRA info
- Link: https://issues.apache.org/jira/browse/HUDI-1187
- Type: Improvement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
