hudi-bot opened a new issue, #15472:
URL: https://github.com/apache/hudi/issues/15472
I feel like this class is a hodgepodge and is ballooning. It does not
demonstrate the benefits of configuration separation that a pluggable
architecture should bring.
if we keep wrap config.getString(ConfigKey) with a getter method such as
config.get{$ConfigKey}() in HoodieWriteConfig, basically we need to include
almost every configKey in every config(such as
HoodieClusteringConfig,HoodieHBaseIndexConfig,HoodieIndexConfig,HoodieStorageConfig
and etc) to HoodieWriteConfig
for the consistent manner and clean code purpose, I think we should inline
all the getter methods that have no logic
## JIRA info
- Link: https://issues.apache.org/jira/browse/HUDI-4964
- Type: Improvement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
