n3nash commented on a change in pull request #2359:
URL: https://github.com/apache/hudi/pull/2359#discussion_r549952800
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/log/AbstractHoodieLogRecordScanner.java
##########
@@ -145,6 +146,11 @@ public void scan() {
// hit a block with instant time greater than should be processed,
stop processing further
break;
}
+ if (r.getBlockType() != CORRUPT_BLOCK && r.getBlockType() !=
COMMAND_BLOCK
+ &&
!timeline.containsOrBeforeTimelineStarts(r.getLogBlockHeader().get(INSTANT_TIME)))
{
+ // hit an invalid block possibly from a failed write, move to the
next one and skip processing this one
Review comment:
Yes, that's why in the comments added "possibly from a failed write".
Changed the invalid -> uncommitted
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
