[GitHub] [hudi] lw309637554 commented on a change in pull request #2379: [HUDI-1399] support a independent clustering spark job to asynchronously clustering

[GitBox]

lw309637554 commented on a change in pull request #2379:
URL: https://github.com/apache/hudi/pull/2379#discussion_r550384675



##########
File path: 
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieDefaultTimeline.java
##########
@@ -95,6 +95,13 @@ public HoodieTimeline filterPendingExcludingCompaction() {
             && 
(!instant.getAction().equals(HoodieTimeline.COMPACTION_ACTION))), details);
   }
 
+  @Override
+  public HoodieTimeline filterPendingExcludingCompactionAndClustering() {
+    return new HoodieDefaultTimeline(instants.stream().filter(instant -> 
(!instant.isCompleted())
+        && (!instant.getAction().equals(HoodieTimeline.COMPACTION_ACTION))
+        && 
(!instant.getAction().equals(HoodieTimeline.REPLACE_COMMIT_ACTION))), details);

Review comment:
       thanks, make sense .

##########
File path: 
hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/DeltaSync.java
##########
@@ -296,7 +296,9 @@ public void refreshTimeline() throws IOException {
     // Retrieve the previous round checkpoints, if any
     Option<String> resumeCheckpointStr = Option.empty();
     if (commitTimelineOpt.isPresent()) {
-      Option<HoodieInstant> lastCommit = commitTimelineOpt.get().lastInstant();
+      // TODO: now not support replace action

Review comment:
       ok




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org