the-other-tim-brown commented on code in PR #17731:
URL: https://github.com/apache/hudi/pull/17731#discussion_r2653821681
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/io/storage/HoodieSparkLanceReader.java:
##########
@@ -108,7 +108,8 @@ public ClosableIterator<HoodieRecord<InternalRow>>
getRecordIterator(HoodieSchem
@Override
public ClosableIterator<HoodieRecord<InternalRow>>
getRecordIterator(HoodieSchema schema) throws IOException {
ClosableIterator<UnsafeRow> iterator = getUnsafeRowIterator(schema);
- return new CloseableMappingIterator<>(iterator, data -> unsafeCast(new
HoodieSparkRecord(data)));
+ //TODO .copy() is needed for correctness, to investigate further in future.
Review Comment:
Can we just solve this as part of this? I am getting worried about the
number of follow on tasks for the baseline features here. If it uses some
shared buffer, then you need to copy. It is similar to other spark iterators
that we have. If it is some setup issue, then fix that first and see if the
copy is still required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
