the-other-tim-brown commented on code in PR #17731:
URL: https://github.com/apache/hudi/pull/17731#discussion_r2654678724
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/io/storage/HoodieSparkLanceWriter.java:
##########
@@ -90,6 +92,22 @@ public HoodieSparkLanceWriter(StoragePath file,
};
}
+ /**
+ * Constructor for Spark Lance writer used for internal row writing with
pre-embedded metadata.
+ *
+ * @param file Path where Lance file will be written
+ * @param sparkSchema Spark schema for the data
+ * @param taskContextSupplier Task context supplier for partition ID
+ * @param storage HoodieStorage instance
+ * @throws IOException if writer initialization fails
+ */
+ public HoodieSparkLanceWriter(StoragePath file,
+ StructType sparkSchema,
+ TaskContextSupplier taskContextSupplier,
+ HoodieStorage storage) throws IOException {
+ this(file, sparkSchema, "0", taskContextSupplier, storage, false);
Review Comment:
Let's make the instant time `null` instead of `"0"` so it is clear it is not
set
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]