the-other-tim-brown commented on code in PR #17758:
URL: https://github.com/apache/hudi/pull/17758#discussion_r2655779884


##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/sources/BaseTestKafkaSource.java:
##########
@@ -71,16 +71,16 @@ public abstract class BaseTestKafkaSource extends 
SparkClientFunctionalTestHarne
   protected final Option<SourceProfileSupplier> sourceProfile = 
Option.of(mock(SourceProfileSupplier.class));
 
   protected SchemaProvider schemaProvider;
-  protected KafkaTestUtils testUtils;
+  protected static KafkaTestUtils testUtils;
 
-  @BeforeEach
-  public void initClass() {
+  @BeforeAll
+  public static void setupKafka() {
     testUtils = new KafkaTestUtils();
     testUtils.setup();
   }
 
-  @AfterEach
-  public void cleanupClass() {
+  @AfterAll

Review Comment:
   It generally doesn't make any impact since the topics are so small but I can 
add it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to