[GitHub] [hudi] lw309637554 commented on a change in pull request #2417: [HUDI-1479] Use HoodieEngineContext to parallelize fetching of partiton paths

[GitBox]

lw309637554 commented on a change in pull request #2417:
URL: https://github.com/apache/hudi/pull/2417#discussion_r554041498



##########
File path: 
hudi-common/src/main/java/org/apache/hudi/common/table/view/FileSystemViewManager.java
##########
@@ -159,12 +160,12 @@ private static HoodieTableFileSystemView 
createInMemoryFileSystemView(Serializab
     return new HoodieTableFileSystemView(metaClient, timeline, 
viewConf.isIncrementalTimelineSyncEnabled());
   }
 
-  public static HoodieTableFileSystemView 
createInMemoryFileSystemView(HoodieTableMetaClient metaClient,
-                                                                       boolean 
useFileListingFromMetadata,
-                                                                       boolean 
verifyListings) {
+  public static HoodieTableFileSystemView 
createInMemoryFileSystemViewForReaders(HoodieTableMetaClient metaClient,
+      boolean useFileListingFromMetadata, boolean verifyListings) {
     LOG.info("Creating InMemory based view for basePath " + 
metaClient.getBasePath());
     if (useFileListingFromMetadata) {
-      return new HoodieMetadataFileSystemView(metaClient,
+      HoodieMREngineContext engineContext = new 
HoodieMREngineContext(metaClient.getHadoopConf());

Review comment:
       @umehrot2 hello, why not use spark EngineContext? Because hudi can run 
just use spark, many users environment just have spark , but not have mr.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org