KiteSoar commented on code in PR #17772:
URL: https://github.com/apache/hudi/pull/17772#discussion_r2658789332
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/common/util/ParquetUtils.java:
##########
@@ -430,7 +430,7 @@ public ByteArrayOutputStream
serializeRecordsToLogBlock(HoodieStorage storage,
//TODO boundary to revisit in follow up to use HoodieSchema directly
Review Comment:
done
##########
hudi-common/src/test/java/org/apache/hudi/common/table/read/TestHoodieFileGroupReaderBase.java:
##########
@@ -726,7 +726,7 @@ private static List<HoodieRecord>
getExpectedHoodieRecordsWithOrderingValue(List
return expectedHoodieRecords.stream().map(rec -> {
List<String> orderingFields =
metaClient.getTableConfig().getOrderingFields();
HoodieAvroIndexedRecord avroRecord = ((HoodieAvroIndexedRecord) rec);
- Comparable orderingValue = OrderingValues.create(orderingFields, field
-> (Comparable) avroRecord.getColumnValueAsJava(avroSchema, field, new
TypedProperties()));
+ Comparable orderingValue = OrderingValues.create(orderingFields, field
-> (Comparable)
avroRecord.getColumnValueAsJava(HoodieSchema.fromAvroSchema(avroSchema), field,
new TypedProperties()));
Review Comment:
done
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/block/HoodieAvroDataBlock.java:
##########
@@ -119,7 +119,7 @@ protected ByteArrayOutputStream
serializeRecords(List<HoodieRecord> records, Hoo
try {
// Encode the record into bytes
// Spark Record not support write avro log
- ByteArrayOutputStream data = s.getAvroBytes(schema, props);
+ ByteArrayOutputStream data =
s.getAvroBytes(HoodieSchema.fromAvroSchema(schema), props);
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
