umehrot2 commented on a change in pull request #2417: URL: https://github.com/apache/hudi/pull/2417#discussion_r554270231
########## File path: hudi-common/src/main/java/org/apache/hudi/common/engine/HoodieMREngineContext.java ########## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.common.engine; + +import org.apache.hadoop.conf.Configuration; +import org.apache.hudi.common.config.SerializableConfiguration; +import org.apache.hudi.common.function.SerializableConsumer; +import org.apache.hudi.common.function.SerializableFunction; +import org.apache.hudi.common.function.SerializablePairFunction; +import org.apache.hudi.common.util.Option; + +import org.apache.hudi.common.util.collection.Pair; + +import java.util.List; +import java.util.Map; +import java.util.stream.Collectors; +import java.util.stream.Stream; + +import static java.util.stream.Collectors.toList; +import static org.apache.hudi.common.function.FunctionWrapper.throwingFlatMapWrapper; +import static org.apache.hudi.common.function.FunctionWrapper.throwingForeachWrapper; +import static org.apache.hudi.common.function.FunctionWrapper.throwingMapToPairWrapper; +import static org.apache.hudi.common.function.FunctionWrapper.throwingMapWrapper; + +/** + * A java based engine context that can be used from map-reduce tasks executing in query engines like + * spark, hive and presto. + */ +public final class HoodieMREngineContext extends HoodieEngineContext { Review comment: Yes but not all commands need spark context. It is created depending on the commands which truly need spark context. Besides this, as discussed offline there is another issue which I encountered when I started to fetch `hadoopConf` from `engineContext` based on your other comment. It results in `NPE` at places when metadata table is created inside spark executor tasks because `engineContext` is not serializable and ends up null at executors. For such scenarios in `HoodieTable` where we create metadata table I will have to add a check to create a `HoodieMREngineContext` in case engine context is `null`. Thus `hudi-client` needs access to this as well. So based on what we agreed to, we need something like a `HoodieLocalEngineContext` that can be used at all these places and can sit in `hudi-common`. ########## File path: hudi-common/src/main/java/org/apache/hudi/metadata/FileSystemBackedTableMetadata.java ########## @@ -49,12 +60,48 @@ public FileSystemBackedTableMetadata(SerializableConfiguration conf, String data @Override public List<String> getAllPartitionPaths() throws IOException { - FileSystem fs = new Path(datasetBasePath).getFileSystem(hadoopConf.get()); if (assumeDatePartitioning) { + FileSystem fs = new Path(datasetBasePath).getFileSystem(hadoopConf.get()); return FSUtils.getAllPartitionFoldersThreeLevelsDown(fs, datasetBasePath); - } else { - return FSUtils.getAllFoldersWithPartitionMetaFile(fs, datasetBasePath); } + + List<Path> pathsToList = new LinkedList<>(); + pathsToList.add(new Path(datasetBasePath)); + List<String> partitionPaths = new ArrayList<>(); + + // TODO: Get the parallelism from HoodieWriteConfig + final int fileListingParallelism = 1500; Review comment: Will do. ########## File path: hudi-common/src/main/java/org/apache/hudi/metadata/FileSystemBackedTableMetadata.java ########## @@ -64,6 +111,6 @@ public FileSystemBackedTableMetadata(SerializableConfiguration conf, String data @Override public boolean isInSync() { - throw new UnsupportedOperationException(); + return false; Review comment: Will do. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
