lw309637554 commented on a change in pull request #2418:
URL: https://github.com/apache/hudi/pull/2418#discussion_r554024960
##########
File path:
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/action/rollback/HoodieClientRollbackTestBase.java
##########
@@ -96,4 +99,61 @@ protected void
twoUpsertCommitDataWithTwoPartitions(List<FileSlice> firstPartiti
assertEquals(1, secondPartitionCommit2FileSlices.size());
}
}
+
+ protected void insertOverwriteCommitDataWithTwoPartitions(List<FileSlice>
firstPartitionCommit2FileSlices,
+ List<FileSlice>
secondPartitionCommit2FileSlices,
+ HoodieWriteConfig
cfg,
+ boolean
commitSecondInsertOverwrite) throws IOException {
+ //just generate two partitions
+ dataGen = new HoodieTestDataGenerator(new
String[]{DEFAULT_FIRST_PARTITION_PATH, DEFAULT_SECOND_PARTITION_PATH});
+ HoodieTestDataGenerator.writePartitionMetadata(fs, new
String[]{DEFAULT_FIRST_PARTITION_PATH, DEFAULT_SECOND_PARTITION_PATH},
basePath);
+ SparkRDDWriteClient client = getHoodieWriteClient(cfg);
+ /**
+ * Write 1 (upsert)
+ */
+ String newCommitTime = "001";
+ List<HoodieRecord> records =
dataGen.generateInsertsContainsAllPartitions(newCommitTime, 2);
Review comment:
this code is the same as twoUpsertCommitDataWithTwoPartitions, can we
reuse it ?
##########
File path:
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/action/rollback/HoodieClientRollbackTestBase.java
##########
@@ -96,4 +99,61 @@ protected void
twoUpsertCommitDataWithTwoPartitions(List<FileSlice> firstPartiti
assertEquals(1, secondPartitionCommit2FileSlices.size());
}
}
+
+ protected void insertOverwriteCommitDataWithTwoPartitions(List<FileSlice>
firstPartitionCommit2FileSlices,
Review comment:
now have the insertOverwriteCommitDataWithTwoPartitions in
HoodieClientRollbackTestBase.java . Is it necessary to add the unit test for
TestMergeOnReadRollbackActionExecutor
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
