yanghua commented on a change in pull request #2430:
URL: https://github.com/apache/hudi/pull/2430#discussion_r556520897
##########
File path: hudi-flink/src/main/java/org/apache/hudi/util/StreamerUtil.java
##########
@@ -81,16 +103,50 @@ public static DFSPropertiesConfiguration
readConfig(FileSystem fs, Path cfgPath,
return conf;
}
- public static Configuration getHadoopConf() {
- return new Configuration();
+ public static org.apache.hadoop.conf.Configuration getHadoopConf() {
+ // create HiveConf from hadoop configuration with hadoop conf directory
configured.
+ org.apache.hadoop.conf.Configuration hadoopConf = null;
+ for (String possibleHadoopConfPath :
HadoopUtils.possibleHadoopConfPaths(new Configuration())) {
Review comment:
What I mean is that can we specify a discovery-order, e.g. first find
the specified path, and then find a batch of default paths.
In some scenarios where storage is separated from computing, or data
synchronization scenarios, users may not necessarily want to load the local
"default" configuration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
