cshuo commented on code in PR #18074:
URL: https://github.com/apache/hudi/pull/18074#discussion_r2757861398
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/source/HoodieSource.java:
##########
Review Comment:
should also set partition pruner for `IncrementalInputSplits` in
DefaultHoodieSplitDiscover.
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/HoodieTableSource.java:
##########
@@ -343,8 +343,14 @@ private HoodieScanContext createHoodieScanContext(RowType
rowType) {
.skipClustering(conf.get(FlinkOptions.READ_STREAMING_SKIP_CLUSTERING))
.skipInsertOverwrite(conf.get(FlinkOptions.READ_STREAMING_SKIP_INSERT_OVERWRITE))
.maxCompactionMemoryInBytes(conf.get(FlinkOptions.COMPACTION_MAX_MEMORY))
- .isStreaming(conf.get(FlinkOptions.READ_AS_STREAMING))
- .build();
+ .isStreaming(conf.get(FlinkOptions.READ_AS_STREAMING));
+
+ // add partition pruner if read with streaming mode.
+ if (conf.get(FlinkOptions.READ_AS_STREAMING)) {
Review Comment:
partition prunning should be enabled for both batch and streaming read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
