prashantwason commented on a change in pull request #2441:
URL: https://github.com/apache/hudi/pull/2441#discussion_r557005212
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java
##########
@@ -371,10 +370,10 @@ private void syncFromInstants(HoodieTableMetaClient
datasetMetaClient) {
Option<List<HoodieRecord>> records =
HoodieTableMetadataUtil.convertInstantToMetaRecords(datasetMetaClient, instant,
metadata.getSyncedInstantTime());
if (records.isPresent()) {
commit(records.get(), MetadataPartitionType.FILES.partitionPath(),
instant.getTimestamp());
+ // re-init the table metadata, for any future writes.
Review comment:
Why not do it once after the for loop?
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/fs/FSUtils.java
##########
@@ -260,9 +260,12 @@ public static void processFiles(FileSystem fs, String
basePathStr, Function<File
if (assumeDatePartitioning) {
return getAllPartitionFoldersThreeLevelsDown(fs, basePathStr);
Review comment:
Why does this not list from metadata table?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
