loukey-lj commented on a change in pull request #2434: URL: https://github.com/apache/hudi/pull/2434#discussion_r557820490
########## File path: hudi-flink/src/main/java/org/apache/hudi/operator/InstantGenerateOperator.java ########## @@ -102,65 +105,76 @@ public void open() throws Exception { // Hadoop FileSystem fs = FSUtils.getFs(cfg.targetBasePath, serializableHadoopConf.get()); - TaskContextSupplier taskContextSupplier = new FlinkTaskContextSupplier(null); + if (isMain) { + TaskContextSupplier taskContextSupplier = new FlinkTaskContextSupplier(null); - // writeClient - writeClient = new HoodieFlinkWriteClient(new HoodieFlinkEngineContext(taskContextSupplier), StreamerUtil.getHoodieClientConfig(cfg), true); + // writeClient + writeClient = new HoodieFlinkWriteClient(new HoodieFlinkEngineContext(taskContextSupplier), StreamerUtil.getHoodieClientConfig(cfg), true); - // init table, create it if not exists. - initTable(); + // init table, create it if not exists. + initTable(); + + // create instantGenerateTmpFolder Review comment: changed to 'create instant marker directory' ########## File path: hudi-flink/src/main/java/org/apache/hudi/operator/InstantGenerateOperator.java ########## @@ -222,4 +236,59 @@ public void close() throws Exception { fs.close(); } } + + private boolean checkReceivedData(long checkpointId) throws InterruptedException, IOException { + int numberOfParallelSubtasks = getRuntimeContext().getNumberOfParallelSubtasks(); + FileStatus[] fileStatuses = null; + Path generatePath = new Path(INSTANT_GENERATE_FOLDER_NAME); + int tryTimes = 1; + // waiting all subtask create generate file ready + while (true) { + Thread.sleep(500L); + fileStatuses = fs.listStatus(generatePath, new PathFilter() { + @Override + public boolean accept(Path pathname) { + return pathname.getName().contains(String.format("_%d_", checkpointId)); Review comment: ok ########## File path: hudi-flink/src/main/java/org/apache/hudi/operator/InstantGenerateOperator.java ########## @@ -222,4 +236,59 @@ public void close() throws Exception { fs.close(); } } + + private boolean checkReceivedData(long checkpointId) throws InterruptedException, IOException { + int numberOfParallelSubtasks = getRuntimeContext().getNumberOfParallelSubtasks(); + FileStatus[] fileStatuses = null; + Path generatePath = new Path(INSTANT_GENERATE_FOLDER_NAME); Review comment: agree ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org