yanghua commented on a change in pull request #2449:
URL: https://github.com/apache/hudi/pull/2449#discussion_r559068852
##########
File path:
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncConfig.java
##########
@@ -49,6 +49,9 @@
@Parameter(names = {"--jdbc-url"}, description = "Hive jdbc connect url",
required = true)
public String jdbcUrl;
+ @Parameter(names = {"--metastore-uri"}, description = "Hive metastore
uri,enable this configuration when synchronizing to remote hive)")
Review comment:
White space between `uri,enable`, Or change to `Hive meta store URI
which enables synchronize to xxx`
##########
File path:
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncConfig.java
##########
@@ -49,6 +49,9 @@
@Parameter(names = {"--jdbc-url"}, description = "Hive jdbc connect url",
required = true)
public String jdbcUrl;
+ @Parameter(names = {"--metastore-uri"}, description = "Hive metastore uri)")
+ public String hiveMetaStoreUri;
+
@Parameter(names = {"--base-path"}, description = "Basepath of hoodie table
to sync", required = true)
Review comment:
@Trevor-zhang Did you address @wangxianghu 's concern?
##########
File path:
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncTool.java
##########
@@ -227,6 +227,9 @@ public static void main(String[] args) {
}
FileSystem fs = FSUtils.getFs(cfg.basePath, new Configuration());
HiveConf hiveConf = new HiveConf();
+ if (cfg.hiveMetaStoreUri != null) {
+ hiveConf.set("hive.metastore.uris",cfg.hiveMetaStoreUri);
Review comment:
Where would we use this config option: `hive.metastore.uris`?
And add white space between `",cfg`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
