voonhous commented on code in PR #17877:
URL: https://github.com/apache/hudi/pull/17877#discussion_r2838245964
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/sources/BaseTestKafkaSource.java:
##########
@@ -323,28 +325,14 @@ public void testKafkaSourceWithOffsetsFromSourceProfile()
{
verify(metrics,
times(2)).updateStreamerSourceBytesToBeIngestedInSyncRound(Long.MAX_VALUE);
}
+ @AllArgsConstructor
+ @Getter
static class TestSourceProfile implements SourceProfile<Long> {
private final long maxSourceBytes;
private final int sourcePartitions;
private final long numEvents;
Review Comment:
Addressed.
My rationale for not including it initially was because there shouldn't be
any harm for including it.
Given that the override a few line down returns it too, there will be 2
methods returning the same field.
Will maintain a 1:1 before and after refactoring, including it the
`AccessLevel.None` so that the getter is not autogen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
