xushiyan commented on code in PR #18212:
URL: https://github.com/apache/hudi/pull/18212#discussion_r2838507929
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/source/reader/function/HoodieSplitReaderFunction.java:
##########
@@ -61,16 +69,21 @@ public HoodieSplitReaderFunction(
HoodieSchema tableSchema,
HoodieSchema requiredSchema,
String mergeType,
- Option<InternalSchema> internalSchemaOption) {
+ Option<InternalSchema> internalSchemaOption,
+ List<ExpressionPredicates.Predicate> predicates,
+ boolean emitDelete) {
ValidationUtils.checkArgument(tableSchema != null, "tableSchema can't be
null");
ValidationUtils.checkArgument(requiredSchema != null, "requiredSchema
can't be null");
this.metaClient = metaClient;
this.tableSchema = tableSchema;
this.requiredSchema = requiredSchema;
+ this.configuration = configuration;
+ this.writeConfig = FlinkWriteClients.getHoodieClientConfig(configuration);
this.internalSchemaOption = internalSchemaOption;
Review Comment:
internalSchemaOption is now dead code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
