danny0405 commented on code in PR #18215:
URL: https://github.com/apache/hudi/pull/18215#discussion_r2844403783
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/timeline/versioning/v1/TimelineArchiverV1.java:
##########
@@ -318,7 +318,8 @@ private List<HoodieInstant> getInstantsToArchive() throws
IOException {
.build();
Option<HoodieInstant> qualifiedEarliestInstant =
TimelineUtils.getEarliestInstantForMetadataArchival(
- dataMetaClient.getActiveTimeline(),
config.shouldArchiveBeyondSavepoint());
+ dataMetaClient.getActiveTimeline(),
config.shouldArchiveBeyondSavepoint(),
+
TimelineUtils.getEarliestRetainedCommitFromLastClean(dataMetaClient));
Review Comment:
The `dataMetaClient.getActiveTimeline()` is passed as a param here, we can
inline the fetch of
`TimelineUtils.getEarliestRetainedCommitFromLastClean(dataMetaClient)` inside
the method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
