prashantwason commented on PR #18061: URL: https://github.com/apache/hudi/pull/18061#issuecomment-3949733755
Rebased with latest master and addressed review comments: **1. Extracted to private method:** Moved the ordering value creation logic to a new private `createOrderingValue()` method. This reduces the complexity of the main code path and makes the logic reusable. **2. Regarding SPARK record type:** After reviewing the code, the SPARK record type (`HoodieSparkRecord`) doesn't use `OrderingValues` in its construction - it uses a different code path that handles ordering through the payload mechanism differently. The `HoodieSparkRecord` constructor takes `(key, targetRow, dataFileStructType, false)` without an ordering value parameter. So the null-check logic isn't directly applicable to SPARK records in the same way. If you think we should add similar validation for SPARK records, please let me know the specific code path where this should be added. @hudi-bot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
