nsivabalan commented on code in PR #18085:
URL: https://github.com/apache/hudi/pull/18085#discussion_r2849365661
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/HoodieStreamerMetrics.java:
##########
@@ -108,6 +108,20 @@ public void updateStreamerMetrics(long durationInNs) {
}
}
+ @Override
+ public void emitStreamerJobSuccessMetrics() {
+ if (writeConfig.isMetricsOn()) {
+ metrics.registerGauge(getMetricsName("deltastreamer", "success"), 1);
Review Comment:
why gauge. wouldn't counter be a right fit here?
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/HoodieStreamerMetrics.java:
##########
@@ -108,6 +108,20 @@ public void updateStreamerMetrics(long durationInNs) {
}
}
+ @Override
+ public void emitStreamerJobSuccessMetrics() {
+ if (writeConfig.isMetricsOn()) {
+ metrics.registerGauge(getMetricsName("deltastreamer", "success"), 1);
+ }
+ }
+
+ @Override
+ public void emitStreamerJobFailedMetrics() {
+ if (writeConfig.isMetricsOn()) {
+ metrics.registerGauge(getMetricsName("deltastreamer", "failure"), 1);
Review Comment:
why gauge. wouldn't counter be a right fit here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
