mansipp commented on code in PR #18238:
URL: https://github.com/apache/hudi/pull/18238#discussion_r2881955511
##########
.github/workflows/pr_todo_validation.yml:
##########
@@ -0,0 +1,53 @@
+name: PR TODO Validation
+
+on:
+ pull_request:
+ types: [opened, edited, reopened, synchronize]
+ branches:
+ - master
+ - branch-0.x
+
+concurrency:
+ group: pr-todo-validation-${{ github.ref }}
+ cancel-in-progress: ${{ !contains(github.ref, 'master') &&
!contains(github.ref, 'branch-0.x') }}
+
+jobs:
+ validate-no-todos:
+ runs-on: ubuntu-latest
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v3
+
+ - name: Extract JIRA issue from PR title
+ id: extract-jira
+ run: |
+ title="${{ github.event.pull_request.title }}"
+ echo "PR title: $title"
+
+ # Extract HUDI-XXXX from title
+ if [[ "$title" =~ \[HUDI-([0-9]+)\] ]]; then
+ jira_id="HUDI-${BASH_REMATCH[1]}"
+ echo "jira_id=$jira_id" >> $GITHUB_OUTPUT
+ echo "Found JIRA ID: $jira_id"
+ else
+ echo "No JIRA ID found in title, skipping validation"
+ echo "jira_id=" >> $GITHUB_OUTPUT
+ fi
Review Comment:
@yihua I agree that it makes more sense to track issues directly in GH
rather than leaving TODOs in the code. We can close this PR along with the
corresponding issue #16654.
Please go ahead and close them if there are no further concerns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
