danny0405 commented on code in PR #18127:
URL: https://github.com/apache/hudi/pull/18127#discussion_r2893758003
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/StreamWriteOperatorCoordinator.java:
##########
@@ -622,6 +622,7 @@ private void doCommit(long checkpointId, String instant,
List<WriteStatus> dataW
// commit and error logging
HashMap<String, String> checkpointCommitMetadata = new HashMap<>();
StreamerUtil.addFlinkCheckpointIdIntoMetaData(conf,
checkpointCommitMetadata, checkpointId);
+ StreamerUtil.addKafkaOffsetMetaData(conf, checkpointCommitMetadata,
checkpointId, null);
Review Comment:
we are not passing nulls explicitly if the method got only 1 invoker, if the
explicit `FlinkCheckpointClient` is for test purposes, we can define another
function and mark it with annotation `@VisibleForTesting`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
