cshuo commented on code in PR #18406: URL: https://github.com/apache/hudi/pull/18406#discussion_r3014058123
########## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/source/reader/HoodieSourceSplitReader.java: ########## @@ -58,17 +59,19 @@ public class HoodieSourceSplitReader<T> implements SplitReader<HoodieRecordWithP private final Queue<HoodieSourceSplit> splits; private final FlinkStreamReadMetrics readerMetrics; private final SplitReaderFunction<T> readerFunction; + private final RecordLimiter recordLimiter; Review Comment: Use `Option<RecordLimiter> recordLimiterOpt` here? When there is no limit pushdown, then it's an empty option, instead of creating an record limiter which is unlimited. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
