n3nash commented on a change in pull request #2496:
URL: https://github.com/apache/hudi/pull/2496#discussion_r567357053
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/fs/HoodieWrapperFileSystem.java
##########
@@ -79,22 +84,51 @@ public static void setMetricsRegistry(Registry registry,
Registry registryMeta)
METRICS_REGISTRY_META = registryMeta;
}
+ // Configs which controls IO buffering and buffer sizes
+ private static final String CONFIG_IO_BUFFER_PREFIX = "hoodie.fs.io.buffer";
Review comment:
@prashantwason Can we move this to a config class like
"HoodieWrapperFileSystemConfig" like this ->
https://github.com/apache/hudi/tree/master/hudi-common/src/main/java/org/apache/hudi/common/config
?
Then you can use the same config in the hudi-client-common and here and
avoid issues when the name scope has changed in one place and hasn't changed in
another.
Let's keep the same names you have the HoodieWriteConfig.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
