wangxianghu commented on a change in pull request #2506: URL: https://github.com/apache/hudi/pull/2506#discussion_r567765521
########## File path: hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/index/state/FlinkInMemoryStateIndex.java ########## @@ -62,47 +61,14 @@ public FlinkInMemoryStateIndex(HoodieFlinkEngineContext context, HoodieWriteConf public List<HoodieRecord<T>> tagLocation(List<HoodieRecord<T>> records, HoodieEngineContext context, HoodieTable<T, List<HoodieRecord<T>>, List<HoodieKey>, List<WriteStatus>> hoodieTable) throws HoodieIndexException { - return context.map(records, record -> { - try { - if (mapState.contains(record.getKey())) { - record.unseal(); - record.setCurrentLocation(mapState.get(record.getKey())); - record.seal(); - } - } catch (Exception e) { - LOG.error(String.format("Tag record location failed, key = %s, %s", record.getRecordKey(), e.getMessage())); - } - return record; - }, 0); + throw new UnsupportedOperationException("No need to tag location for FlinkInMemoryStateIndex"); Review comment: @danny0405 if we do not query the location, how to identify the operation per record is insert or update ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org