yanghua commented on a change in pull request #2506:
URL: https://github.com/apache/hudi/pull/2506#discussion_r569535044
##########
File path:
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/client/HoodieFlinkWriteClient.java
##########
@@ -249,7 +250,17 @@ public String getLastCompletedInstant(String tableType) {
public void deletePendingInstant(String tableType, String instant) {
HoodieFlinkTable<T> table = HoodieFlinkTable.create(config,
(HoodieFlinkEngineContext) context);
String commitType =
CommitUtils.getCommitActionType(HoodieTableType.valueOf(tableType));
- table.getMetaClient().getActiveTimeline()
- .deletePending(new HoodieInstant(HoodieInstant.State.REQUESTED,
commitType, instant));
+ HoodieActiveTimeline activeTimeline =
table.getMetaClient().getActiveTimeline();
+ activeTimeline.deletePending(new
HoodieInstant(HoodieInstant.State.INFLIGHT, commitType, instant));
+ activeTimeline.deletePending(new
HoodieInstant(HoodieInstant.State.REQUESTED, commitType, instant));
+ }
+
+ public void transitionRequestedToInflight(String tableType, String
inFlightInstant) {
Review comment:
Fine, let us stop arguing. After consulting the English dictionary, it
seems that `transit` and `transition` have both the attributes of nouns and
verbs, but they have slightly different meanings. Here I don’t want to entangle
this focus anymore, let us spend our energy on more meaningful things. WDYT?
+1 for staying the same here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
