wombatu-kun commented on code in PR #18403: URL: https://github.com/apache/hudi/pull/18403#discussion_r3180529336
########## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/execution/datasources/lance/SparkLanceReaderBase.scala: ########## Review Comment: Added in 104a52f2. Gate sits in `SparkLanceReaderBase.read` rather than `supportBatch` because the file-format hook only sees the data schema, not partitionSchema. `isPartitionTypeSupportedForBatch` covers exactly the set the populator handles (Boolean/Byte/Short/Int/Date/Long/Timestamp/TimestampNTZ/Float/Double/String/Decimal/Binary); when any partition type is unsupported, batch mode falls back to the row path where `JoinedRow` preserves the value. The previous silent-null `case _` in `populatePartitionVectors` is now `throw IllegalStateException`, so any future regression in the gate fails loud instead of nulling user data. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
