hudi-agent commented on code in PR #18689:
URL: https://github.com/apache/hudi/pull/18689#discussion_r3183294896
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/helpers/KinesisReadConfig.java:
##########
@@ -41,12 +42,22 @@ public class KinesisReadConfig implements Serializable {
private final String accessKey; // null if not set
private final String secretKey; // null if not set
private final KinesisSourceConfig.KinesisStartingPositionStrategy
startingPosition;
+ @Getter(AccessLevel.NONE)
private final boolean shouldAddMetaFields;
+ @Getter(AccessLevel.NONE)
private final boolean enableDeaggregation;
private final int maxRecordsPerRequest;
private final long intervalMilliSeconds;
private final long maxRecordsPerShard;
private final long retryInitialIntervalMs;
private final long retryMaxIntervalMs;
private final long throttleTimeoutMs;
+
+ public boolean shouldAddMetaFields() {
+ return shouldAddMetaFields;
+ }
+
+ public boolean isDeaggregationEnabled() {
+ return enableDeaggregation;
Review Comment:
🤖 nit: the getter is `isDeaggregationEnabled()` (adjective form) but the
backing field is `enableDeaggregation` (verb form) — could you rename the field
to `deaggregationEnabled` to keep them consistent?
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
