hudi-agent commented on code in PR #18439:
URL: https://github.com/apache/hudi/pull/18439#discussion_r3190068803
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/lock/StorageBasedLockProvider.java:
##########
@@ -346,9 +352,24 @@ public synchronized boolean tryLock() {
newLockData,
latestLock.getRight());
if (lockUpdateStatus.getLeft() != LockUpsertResult.SUCCESS) {
- // failed to acquire the lock, indicates concurrent contention
logInfoLockState(FAILED_TO_ACQUIRE);
-
hoodieLockMetrics.ifPresent(HoodieLockMetrics::updateLockAcquirePreconditionFailureMetric);
+ switch (lockUpdateStatus.getLeft()) {
+ case ACQUIRED_BY_OTHERS:
+ // failed to acquire the lock, indicates concurrent contention
+
hoodieLockMetrics.ifPresent(HoodieLockMetrics::updateLockAcquirePreconditionFailureMetric);
+ break;
+ case THROTTLED:
Review Comment:
🤖 nit: `THROTTLED` and `UNKNOWN_ERROR` do exactly the same thing here —
could you collapse them into a single `case THROTTLED: case UNKNOWN_ERROR:`
block to avoid the duplication?
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
