prashantwason commented on PR #18669: URL: https://github.com/apache/hudi/pull/18669#issuecomment-4400327936
@lokeshj1703 @yihua - this PR is green on the latest commit 5e25a570dd0f: 62/62 checks passing. Quick history of the recent commits in case it helps the re-review: - bd4e4c24 - applied a hudi-agent nit to drop `Option(schema).getOrElse(new StructType())` in favor of `schema` directly, on the assumption that `SchemaRelationProvider` guarantees non-null schema. - 5e25a570 - reverted bd4e4c24. The 2-arg `createRelation` overload (line 78 of `DefaultSource.scala`) re-enters the 3-arg overload with `schema = null`, so the defensive fallback was load-bearing. Without it, `TestCOWDataSource.testReadOfAnEmptyTable` NPE'd on spark3.3 / spark3.5. The comment above the catch now explicitly calls out the internal-recursion reason so future readers don't strip it again. Net effect vs your prior approval: same as 43e0dd49 semantically + one extra clarifying sentence in the comment. Ready to merge whenever you have a moment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
