xushiyan commented on code in PR #596:
URL: https://github.com/apache/hudi-rs/pull/596#discussion_r3204170994
##########
crates/core/Cargo.toml:
##########
@@ -81,6 +81,12 @@ prost = { workspace = true }
# compression
flate2 = { workspace = true }
+# lance
+lance-core = { version = "4.0.1" }
+lance-encoding = { version = "4.0.1" }
+lance-file = { version = "4.0.1" }
+lance-io = { version = "4.0.1" }
Review Comment:
Pushing back. Lance support was intentionally made unconditional in 3cd8932f
(`build(core): make lance support unconditional`) — `hudi-core` no longer
carries a per-feature MSRV exception, the workspace MSRV is 1.91.1, and CI runs
without a separate `lance` feature matrix. Re-introducing a feature flag would
resurrect that complexity (separate MSRV, separate cfg-gated modules, optional
deps) for a feature we want enabled in every consumer. Closing as won't-fix.
##########
crates/core/src/storage/error.rs:
##########
@@ -49,6 +49,9 @@ pub enum StorageError {
#[error(transparent)]
ParquetError(#[from] parquet::errors::ParquetError),
Review Comment:
Pushing back. Lance support was intentionally made unconditional in 3cd8932f
(`build(core): make lance support unconditional`) — `hudi-core` no longer
carries a per-feature MSRV exception, the workspace MSRV is 1.91.1, and CI runs
without a separate `lance` feature matrix. Re-introducing a feature flag would
resurrect that complexity (separate MSRV, separate cfg-gated modules, optional
deps) for a feature we want enabled in every consumer. Closing as won't-fix.
##########
crates/core/src/file_group/base_file/mod.rs:
##########
@@ -16,6 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
+pub mod lance;
pub mod parquet;
pub mod reader;
Review Comment:
Pushing back. Lance support was intentionally made unconditional in 3cd8932f
(`build(core): make lance support unconditional`) — `hudi-core` no longer
carries a per-feature MSRV exception, the workspace MSRV is 1.91.1, and CI runs
without a separate `lance` feature matrix. Re-introducing a feature flag would
resurrect that complexity (separate MSRV, separate cfg-gated modules, optional
deps) for a feature we want enabled in every consumer. Closing as won't-fix.
##########
crates/core/src/schema/resolver.rs:
##########
@@ -20,6 +20,7 @@ use crate::avro_to_arrow::to_arrow_schema;
use crate::config::table::BaseFileFormatValue;
use crate::config::table::HudiTableConfig;
use crate::error::{CoreError, Result};
+use crate::file_group::base_file::lance::LanceBaseFileReader;
use crate::file_group::base_file::parquet::ParquetBaseFileReader;
use crate::metadata::commit::HoodieCommitMetadata;
Review Comment:
Pushing back. Lance support was intentionally made unconditional in 3cd8932f
(`build(core): make lance support unconditional`) — `hudi-core` no longer
carries a per-feature MSRV exception, the workspace MSRV is 1.91.1, and CI runs
without a separate `lance` feature matrix. Re-introducing a feature flag would
resurrect that complexity (separate MSRV, separate cfg-gated modules, optional
deps) for a feature we want enabled in every consumer. Closing as won't-fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
