wombatu-kun commented on code in PR #18375:
URL: https://github.com/apache/hudi/pull/18375#discussion_r3205808355
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -327,7 +327,11 @@ public class HoodieWriteConfig extends HoodieConfig {
public static final ConfigProperty<HoodieFileFormat> BASE_FILE_FORMAT =
ConfigProperty
.key("hoodie.base.file.format")
.defaultValue(HoodieFileFormat.PARQUET)
- .withValidValues(HoodieFileFormat.PARQUET.name(),
HoodieFileFormat.ORC.name(), HoodieFileFormat.HFILE.name())
+ .withValidValues(
+ HoodieFileFormat.PARQUET.name(),
+ HoodieFileFormat.ORC.name(),
+ HoodieFileFormat.HFILE.name(),
+ HoodieFileFormat.LANCE.name())
Review Comment:
Fixed in `632207766a33`. Added a `LANCE` branch to `getMaxFileSize`
returning `getParquetMaxFileSize()` — Lance is a columnar Parquet-like format
at the sizing layer, so reusing the parquet limit is a defensible default until
a dedicated `hoodie.lance.max.file.size` is introduced. The only current call
site (`BaseConsistentHashingBucketClusteringPlanStrategy.getSplit/MergeSize`)
is outside the COW + base-upserts surface this PR exercises, but the runtime
throw is now closed off.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
