n3nash commented on a change in pull request #2359:
URL: https://github.com/apache/hudi/pull/2359#discussion_r578081554
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java
##########
@@ -181,7 +171,7 @@ public boolean commitStats(String instantTime,
List<HoodieWriteStat> stats, Opti
HoodieCommitMetadata metadata = CommitUtils.buildMetadata(stats,
partitionToReplaceFileIds, extraMetadata, operationType, config.getSchema(),
commitActionType);
// Finalize write
finalizeWrite(table, instantTime, stats);
-
+ HeartbeatUtils.abortIfHeartbeatExpired(instantTime, table,
heartbeatClient, config);
Review comment:
I want to avoid business logic like approach 2 in the
`AbstractHoodieWriteClient`, this logic is pushed to the method
`abortIfHeartbeatExpired`. Alternatively, the method `abortIfHeartbeatExpired`
build on other public API's to be able to do custom business logic if needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
