hudi-agent commented on code in PR #18718:
URL: https://github.com/apache/hudi/pull/18718#discussion_r3239009872
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/client/transaction/lock/TestStorageBasedLockProvider.java:
##########
@@ -516,6 +521,29 @@ void testRenewLockSucceeds() {
eq(this.ownerId), anyLong(),
eq("gs://bucket/lake/db/tbl-default/.hoodie/.locks/table_lock.json"));
}
+ @Test
+ void testRenewLockUpdatesMetricWithRenewedExpirationDeadline() {
+ HoodieLockMetrics lockMetrics = mock(HoodieLockMetrics.class);
Review Comment:
🤖 nit: every other mock in this test class uses the `mock` prefix
(`mockLockService`, `mockHeartbeatManager`, `mockLogger`, `mockMetrics`) —
could you rename `lockMetrics` to `mockLockMetrics` to stay consistent?
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
