hudi-agent commented on code in PR #18743:
URL: https://github.com/apache/hudi/pull/18743#discussion_r3246153948
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/common/AbstractStreamWriteFunction.java:
##########
@@ -176,6 +176,13 @@ public void endInput() {
this.inputEnded = true;
}
+ @Override
+ public void close() throws Exception {
+ if (this.writeClient != null) {
Review Comment:
🤖 Should this also call `super.close()` to chain to the parent
(`ProcessFunctionAdapter` / `RichFunction`)? Subclasses like
`StreamWriteFunction` and `IndexWriteFunction` invoke `super.close()` at the
end of their own `close()`, which now lands here — and stops, leaving anything
the Flink base class needs to clean up unhandled. Wrapping the
`writeClient.close()` in a try/finally with `super.close()` in the finally
would also ensure cleanup proceeds if the write client throws.
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
