hudi-agent commented on code in PR #18749:
URL: https://github.com/apache/hudi/pull/18749#discussion_r3250078417


##########
release/release_guide.md:
##########
@@ -433,16 +433,25 @@ Set up a few environment variables to simplify Maven 
commands that follow. This
       hudi-spark3-bundle-2.12/2.13, hudi-spark-2.12/2.13, 
hudi-spark3-2.12/2.13, hudi-utilities-bundle_2.12/2.13 and
       hudi-utilities_2.12/2.13.
       > With 0.10.1, we had 4 bundles. spark2 with scala11, spark2 with 
scala12, spark3.0.x bundles and spark3.1.x bundles. Ensure each spark bundle 
reflects the version correctly. hudi-spark3.1.2-bundle_2.12-0.10.1.jar and 
hudi-spark3.0.3-bundle_2.12-0.10.1.jar are the respective bundle names for 
spark3 bundles.
-   8. Once you have ensured everything is good and validation of step 7 
succeeds, you can close the staging repo. Until
+   8. Before closing the staging repo, run the validate script against the 
private staging URL to programmatically
+      confirm all expected bundle artifacts are present. The `--auth` flag 
reads Nexus credentials from
+      `~/.m2/settings.xml` (server id `apache.releases.https`), which is 
required because the public URL is not
+      populated until the repo is closed.
+      ```shell
+      ./scripts/release/validate_staged_bundles.sh --auth 
orgapachehudi-<stage_repo_number> ${RELEASE_VERSION}-rc${RC_NUM} 2>&1 | tee -a 
/tmp/validate_staged_bundles_output.txt

Review Comment:
   🤖 It might help to clarify which `deploy_staging_jars*.sh` invocation to 
re-run when artifacts are missing. Step 9.4 above splits the upload into a Java 
11 run (`deploy_staging_jars.sh`) and a Java 17 run for Spark 4 
(`deploy_staging_jars_java17.sh`), and the release manager would need to know 
which script corresponds to the missing bundle (e.g. a missing 
`hudi-spark4.x-bundle` points back to the Java 17 script). A brief hint here — 
or a pointer back to step 9.4 — would save a release manager from guessing 
under time pressure.
   
   <sub><i>- AI-generated; verify before applying. React 👍/👎 to flag 
quality.</i></sub>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to