nsivabalan commented on a change in pull request #2188:
URL: https://github.com/apache/hudi/pull/2188#discussion_r580441277
##########
File path:
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/index/hbase/TestHBaseIndex.java
##########
@@ -268,6 +268,66 @@ public void testTagLocationAndDuplicateUpdate() throws
Exception {
&&
record.getCurrentLocation().getInstantTime().equals(newCommitTime))).distinct().count());
}
+ @Test
+ public void testTagLocationAndPartitionPathUpdateWithExplicitRollback()
throws Exception {
+ final int numRecords = 10;
+ final String oldPartitionPath = "1970/01/01";
+ final String emptyHoodieRecordPayloadClasssName =
EmptyHoodieRecordPayload.class.getName();
+ HoodieWriteConfig config = getConfig(true);
+ SparkHoodieHBaseIndex index = new SparkHoodieHBaseIndex(getConfig(true));
Review comment:
Can you point me to the place where we set the new config to true.
##########
File path:
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/index/hbase/SparkHoodieHBaseIndex.java
##########
@@ -537,7 +545,71 @@ private Integer getNumRegionServersAliveForTable() {
@Override
public boolean rollbackCommit(String instantTime) {
- // Rollback in HbaseIndex is managed via method {@link
#checkIfValidCommit()}
+ int multiGetBatchSize = config.getHbaseIndexGetBatchSize();
+ boolean rollbackSync = config.getHBaseIndexRollbackSync();
+
+ if (!config.getHbaseIndexUpdatePartitionPath()) {
Review comment:
getHBaseIndexRollbackSync
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
