rahil-c commented on code in PR #18744: URL: https://github.com/apache/hudi/pull/18744#discussion_r3261395382
########## hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestLanceDataSource.scala: ########## Review Comment: Thanks for the comprehensive testing @voonhous. Can you add tests for the cases @yihua was showing today regarding doing a select * from a table has multiple blob cols, like blob_A, blob_B. ``` select read_blob(blob_col1), blob_col2 from table mode = CONTENT, return content both columns mode = DESCRIPTOR (default), throw error select blob_col1, blob_col2 from table mode = CONTENT, return content both columns mode = DESCRIPTOR (default), return discriptor select read_blob(blob_col1), read_blob(blob_col2) from table return content for columns ``` Essentially we want to ensure that when a user does `select read_blob(blob_A), blob_B from table`, with default as DESCRIPTOR that this would throw error as we have a mixed case here for bytes and pointers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
