nsivabalan commented on code in PR #18384:
URL: https://github.com/apache/hudi/pull/18384#discussion_r3269609034
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/io/storage/row/HoodieInternalRowFileWriterFactory.java:
##########
@@ -104,8 +105,10 @@ private static HoodieInternalRowFileWriter
newLanceInternalRowFileWriter(Storage
}
private static Option<BloomFilter>
tryInstantiateBloomFilter(HoodieWriteConfig writeConfig) {
- // NOTE: Currently Bloom Filter is only going to be populated if
meta-fields are populated
- if (writeConfig.populateMetaFields()) {
+ // NOTE: Bloom Filter indexes record keys, so it is only populated if
meta-fields are populated
+ // and record_key is not excluded
+ MetadataFieldsPopulation populateFlags =
writeConfig.getMetaFieldPopulationFlags();
Review Comment:
I pushed out a fix to revert these. we should be enabling bloom irrespective
of virtual keys config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
