hudi-agent commented on code in PR #18789:
URL: https://github.com/apache/hudi/pull/18789#discussion_r3273398277
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/StreamWriteOperatorCoordinator.java:
##########
@@ -773,7 +773,7 @@ private TableState(Configuration conf) {
this.syncMetadata = conf.get(FlinkOptions.METADATA_ENABLED);
this.isDeltaTimeCompaction = OptionsResolver.isDeltaTimeCompaction(conf);
this.isStreamingIndexWriteEnabled =
OptionsResolver.isStreamingIndexWriteEnabled(conf);
- this.isRLIWithBootstrap = OptionsResolver.isRLIWithBootstrap(conf);
+ this.isRecordLevelIndex = OptionsResolver.isGlobalRecordLevelIndex(conf)
|| OptionsResolver.isRecordLevelIndex(conf);
Review Comment:
🤖 nit: the field is named `isRecordLevelIndex` but it's the union of both
variants (`isGlobalRecordLevelIndex || isRecordLevelIndex`), while
`OptionsResolver.isRecordLevelIndex()` covers only one of the two. A future
reader seeing `tableState.isRecordLevelIndex` at a call site might assume it's
the narrower check. Could you use something like `isAnyRecordLevelIndex` or
`hasRecordLevelIndex` to make the breadth explicit?
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
