hudi-agent commented on code in PR #17591:
URL: https://github.com/apache/hudi/pull/17591#discussion_r3281362709
##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/client/common/HoodieFlinkEngineContext.java:
##########
@@ -112,6 +113,13 @@ public <T> HoodieData<T> parallelize(List<T> data, int
parallelism) {
return HoodieListData.eager(data);
}
+ @Override
+ public <T> HoodieData<T> union(List<HoodieData<T>> dataList) {
+ List<T> allData = new ArrayList<>();
+ dataList.forEach(entry -> allData.addAll(entry.collectAsList()));
Review Comment:
🤖 nit: `entry` reads like a `Map.Entry` here — could you rename it to
`hoodieData` (consistent with the outer parameter name convention in this
class)? Same pattern is repeated in `HoodieJavaEngineContext` and
`HoodieLocalEngineContext`.
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/common/HoodieSparkEngineContext.java:
##########
@@ -135,6 +135,16 @@ public <T> HoodieData<T> parallelize(List<T> data, int
parallelism) {
return HoodieJavaRDD.of(javaSparkContext.parallelize(data, parallelism));
}
+ @Override
+ public <T> HoodieData<T> union(List<HoodieData<T>> dataList) {
+ List<JavaRDD<T>> javaRDDList = dataList.stream().map(hoodieData ->
HoodieJavaRDD.getJavaRDD(hoodieData)).collect(Collectors.toList());
Review Comment:
🤖 nit: `map(hoodieData -> HoodieJavaRDD.getJavaRDD(hoodieData))` could be
simplified to `map(HoodieJavaRDD::getJavaRDD)` — the method reference is a bit
cleaner here.
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
