yihua commented on code in PR #18786:
URL: https://github.com/apache/hudi/pull/18786#discussion_r3283505499
##########
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/analysis/HoodieAnalysis.scala:
##########
@@ -101,12 +98,8 @@ object HoodieAnalysis extends SparkAdapterSupport {
"org.apache.spark.sql.hudi.Spark40ResolveHudiAlterTableCommand"
} else if (HoodieSparkUtils.gteqSpark3_5) {
"org.apache.spark.sql.hudi.Spark35ResolveHudiAlterTableCommand"
- } else if (HoodieSparkUtils.isSpark3_4) {
- "org.apache.spark.sql.hudi.Spark34ResolveHudiAlterTableCommand"
- } else if (HoodieSparkUtils.isSpark3_3) {
- "org.apache.spark.sql.hudi.Spark33ResolveHudiAlterTableCommand"
} else {
- throw new IllegalStateException("Unsupported Spark version")
+ "org.apache.spark.sql.hudi.Spark34ResolveHudiAlterTableCommand"
Review Comment:
I cleaned this up to use only if-else branches to be consistent across the
board, since we now compile against Spark 3.5 and 3.4. Having `throw new
IllegalStateException("Unsupported Spark version")` is redundant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
