[GitHub] [hudi] satishkotha commented on a change in pull request #2584: [Hudi-1583]: Fix bug that Hudi will skip remaining log files if there is logFile with zero size in logFileList when merge on read.

[GitBox]

satishkotha commented on a change in pull request #2584:
URL: https://github.com/apache/hudi/pull/2584#discussion_r583398027



##########
File path: 
hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieLogFormatReader.java
##########
@@ -104,7 +104,7 @@ public boolean hasNext() {
         throw new HoodieIOException("unable to initialize read with log file 
", io);
       }
       LOG.info("Moving to the next reader for logfile " + 
currentReader.getLogFile());
-      return this.currentReader.hasNext();
+      return this.currentReader.hasNext() || hasNext();

Review comment:
       can we just call hasNext() here to simplify? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org