n3nash commented on a change in pull request #2595:
URL: https://github.com/apache/hudi/pull/2595#discussion_r584092113
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java
##########
@@ -235,6 +235,29 @@ protected void initTableMetadata() {
protected void bootstrapIfNeeded(HoodieEngineContext engineContext,
HoodieTableMetaClient datasetMetaClient) throws IOException {
HoodieTimer timer = new HoodieTimer().startTimer();
boolean exists = datasetMetaClient.getFs().exists(new
Path(metadataWriteConfig.getBasePath(), HoodieTableMetaClient.METAFOLDER_NAME));
+ boolean rebootstrap = false;
+ if (exists) {
+ // If the un-synched instants have been archived then the metadata table
will need to be bootstrapped again
Review comment:
@prashantwason Thinking about this after today's discussion, will there
ever be a situation when un-synced instants will be archived ? Given the
`syncMetadataTable` happens before everything (in the
AbstractHoodieWriteClient) and after commit, there should never be an instance
like this ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
