hudi-agent commented on code in PR #18824:
URL: https://github.com/apache/hudi/pull/18824#discussion_r3291619905
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieMetadataWriteUtils.java:
##########
@@ -136,6 +140,21 @@ public class HoodieMetadataWriteUtils {
// eventually depend on the number of file groups selected for each
partition (See estimateFileGroupCount function)
private static final long MDT_MAX_HFILE_SIZE_BYTES = 10 * 1024 * 1024 *
1024L; // 10GB
+ // Configs that control the spillable-map machinery used by the MDT writer
and compactor
+ // (ExternalSpillableMap + HoodieMergedLogRecordScanner). The MDT
HoodieWriteConfig is
+ // built from scratch and does not otherwise inherit HoodieCommonConfig /
HoodieMemoryConfig
+ // values, so without explicit propagation user overrides set on the
data-table write
+ // config are silently ignored by the MDT writer/compactor.
+ private static final List<ConfigProperty<?>>
MDT_INHERITED_SPILLABLE_MAP_CONFIGS = Arrays.asList(
Review Comment:
🤖 nit: since `MDT_INHERITED_SPILLABLE_MAP_CONFIGS` is a `private static
final` constant, could you use `List.of(...)` instead of `Arrays.asList(...)`
to make it genuinely immutable?
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
