danny0405 commented on code in PR #18824:
URL: https://github.com/apache/hudi/pull/18824#discussion_r3303518266
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieMetadataWriteUtils.java:
##########
@@ -279,6 +298,21 @@ public static HoodieWriteConfig createMetadataWriteConfig(
.withWriteConcurrencyMode(concurrencyMode)
.withLockConfig(lockConfig);
+ // Inherit spillable-map / memory configs so user overrides (e.g.
+ // hoodie.common.spillable.diskmap.type=ROCKS_DB) actually reach the MDT
+ // writer/compactor. Guarded by containsKey so that configs without
defaults
+ // (e.g. SPILLABLE_MAP_BASE_PATH, MAX_MEMORY_FOR_COMPACTION) aren't forged
+ // into "user-set" on the MDT side when the user hasn't set them.
+ Properties spillableMapProperties = new Properties();
Review Comment:
or we can just put the props into the one in line 317.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
