skywalker0618 commented on code in PR #18813:
URL: https://github.com/apache/hudi/pull/18813#discussion_r3313112302
##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/sink/partitioner/index/TestRecordLevelIndexBackend.java:
##########
@@ -187,4 +224,18 @@ public Map<Long, String> requestInflightInstants() {
return inflightInstants;
}
}
+
+ private static class CapturingMetricGroup extends UnregisteredMetricsGroup {
Review Comment:
There are three CapturingMetricGroup inner classes in test code:
1. TestRecordLevelIndexBackend: histogram only.
2. TestFlinkPartitionedIndexBackendMetrics: histogram only (literal copy of
1).
3. TestFlinkIndexBackendMetrics (pre-existing): histogram and gauge.
So strictly speaking, 1 and 2 are identical; 3 is a strict superset.
Cross-package sharing forces a public surface. The two test files live in
different packages:
org.apache.hudi.metrics (the new metrics test)
org.apache.hudi.sink.partitioner.index (the backend test)
Too much change for this so prefer not going this route
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
