hudi-agent commented on code in PR #18837:
URL: https://github.com/apache/hudi/pull/18837#discussion_r3317485924
##########
docker/hoodie/hadoop/pom.xml:
##########
@@ -39,9 +39,6 @@
<module>sparkworker</module>
<module>sparkadhoc</module>
<module>prestobase</module>
- <module>trinobase</module>
- <module>trinocoordinator</module>
- <module>trinoworker</module>
</modules>
Review Comment:
🤖 Nice cleanup of the three trino module poms — this addresses the orphan
`hudi-trino-bundle.jar` copy that was flagged earlier. A few related orphans
still appear to reference the removed modules though — could these be cleaned
up in the same pass? Specifically: 1) the leftover `Dockerfile`, `scripts/`,
and `etc/` files under `docker/hoodie/hadoop/trino{base,coordinator,worker}/`
are now unreachable (Dockerfile still tries to `cp hudi-trino-bundle.jar`); 2)
`docker/compose/docker-compose_hadoop284_hive2310_spark353_{amd64,arm64}.yml`
still declare `trino-coordinator-1`/`trino-worker-1` services pointing at
images that will no longer be built; 3) `docker/README.md` (lines 28, 42,
66-67, 87-88, 105) still documents `trinobase` build steps; 4)
`scripts/release/validate_staged_bundles.sh:91` still lists `hudi-trino-bundle`
in the bundles to validate, which will fail on the next release.
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
